Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

bugs found in functional testing on cluster #71

Closed
scottleedavis opened this issue Apr 26, 2019 · 15 comments
Closed

bugs found in functional testing on cluster #71

scottleedavis opened this issue Apr 26, 2019 · 15 comments
Assignees
Labels
Type/Bug Something isn't working

Comments

@scottleedavis
Copy link
Owner

scottleedavis commented Apr 26, 2019

### 1) display time is correct on local, but not on cluster . fixed by timezone fix
right-display-local
wrong-display-community

### 2) 'at' time fires local, but not on cluster . fixed by timezone fix
'at' time fires local
'at' time never fires community

@scottleedavis scottleedavis added the Type/Bug Something isn't working label Apr 26, 2019
@scottleedavis scottleedavis self-assigned this Apr 26, 2019
@scottleedavis
Copy link
Owner Author

scottleedavis commented Apr 28, 2019

/remind me check at <some time> is not triggering fixed. timezone issue

scottleedavis added a commit that referenced this issue Apr 28, 2019
@tschlue
Copy link

tschlue commented May 2, 2019

Mattermost Version: 5.10.0
remind Version: 0.2.0

mmtimezonebug

@scottleedavis scottleedavis reopened this May 2, 2019
@scottleedavis scottleedavis added this to the 0.2.1 milestone May 2, 2019
@scottleedavis
Copy link
Owner Author

@tschlue could you share the command that produced this output?

@tschlue
Copy link

tschlue commented May 3, 2019

/remind me in 1 min

@scottleedavis
Copy link
Owner Author

Ah! that should return an error instead of schedule a reminder. thank you.
/remind me a message in 1 min (e.g. /remind me|@user|~channel message time)

@tschlue
Copy link

tschlue commented May 6, 2019

Okay, but this doesn't fix the time problem.

@tschlue
Copy link

tschlue commented May 6, 2019

I think would like to use empty messages, just to remind me to look at mattermost or to wakeup a channel.

@scottleedavis scottleedavis reopened this May 6, 2019
@scottleedavis scottleedavis removed this from the 0.2.1 milestone May 6, 2019
@scottleedavis
Copy link
Owner Author

For empty messages you can use empty double quotes. e.g. /remind me "" in 1 min. Slackbot doesn't permit empty messages except in this fashion as well.

I hadn't noticed the time issue until now. Could you share /remind __user ? What server tech are you using? docker? debian? other? Could you try Experimental -> timezone enabled?

@tschlue
Copy link

tschlue commented May 6, 2019

System
17:46(Only visible to you)
×
locale: en
location: America/Atikokan

@scottleedavis
Copy link
Owner Author

@tschlue could you try the bot-test plugin to see if it matches the header time of the post?
/test-time returns time. should match post header
https://github.com/scottleedavis/mattermost-plugin-bot-test/releases/tag/v0.1.2

@tschlue
Copy link

tschlue commented May 7, 2019

grafik

@scottleedavis
Copy link
Owner Author

@tschlue I could replicate this by changing my timezone on my laptop. I could also fix it by enabling experimental timezone support. Would you try that out and let me know?

System Console -> Experimental Features -> Timezone = true

@tschlue
Copy link

tschlue commented May 8, 2019

@scottleedavis This fix the problem apparently but is this necessary?

@scottleedavis
Copy link
Owner Author

@tschlue No, however it is quickest. I created #94 to take webapp timezone detection into account.

@tschlue
Copy link

tschlue commented May 8, 2019

thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants