Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-deterministic order of gulp streams causes potential build hash change #120

Closed
scottohara opened this issue Aug 16, 2017 · 1 comment

Comments

@scottohara
Copy link
Owner

scottohara commented Aug 16, 2017

The order of gulp streams is not guaranteed (see gulpjs/gulp#687, and here).

This can sometimes cause gulp-concat to produce a different file (which in turn causes gulp-rev to produce a different hash), even when the source files are unchanged.

The long term solution for this is obviously to move away from concatenating scripts, and to start using modules and bundler such as webpack.

As a short term fix, an attempt was made to use gulp-sort to reorder the streams, however this was rolled back because it broke the build.

@scottohara
Copy link
Owner Author

This becomes redundant with the move to webpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant