Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blob not found when iterating over local container #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

habibutsu
Copy link
Contributor

Fix for #80

@felixevers
Copy link

Hello everyone!
I would like to push this pr!
Unfortunately is the pipeline still failing - @habibutsu @scottwernervt

We all know that there is no directory concept in "normal" object storage.
So after each deletion we should check if there are empty directories left.
Ignoring those empty dirs could lead to bad expericences using this local storage abstraction layer.
This project needs more maintenance!

@zevisert
Copy link

Looking for this PR today too

@zevisert
Copy link

@use-to I have a branch with that directory cleanup working: zevisert@a915969

If @scottwernervt shows some activity here I'll put up an MR, but for now I've just been installing cloudstorage as a git dependency - using poetry that'd look like this:

[tool.poetry.dependencies]
cloudstorage = {git = "https://github.com/zevisert/cloudstorage.git", rev="a9159695b0074e4ede9cb9525f0aaeddc98269d3", extras = ["local", "google"]}

@felixevers
Copy link

@use-to I have a branch with that directory cleanup working: zevisert@a915969

If @scottwernervt shows some activity here I'll put up an MR, but for now I've just been installing cloudstorage as a git dependency - using poetry that'd look like this:

[tool.poetry.dependencies]
cloudstorage = {git = "https://github.com/zevisert/cloudstorage.git", rev="a9159695b0074e4ede9cb9525f0aaeddc98269d3", extras = ["local", "google"]}

Thank you for sharing and caring. Maybe we should establish an working fork here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants