Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary VC support #26

Merged
merged 61 commits into from
Aug 14, 2024
Merged

Add preliminary VC support #26

merged 61 commits into from
Aug 14, 2024

Conversation

scouten-adobe
Copy link
Owner

EARLY DRAFT: Add support for verifiable credentials in CAWG identity assertion

@scouten-adobe scouten-adobe self-assigned this Jul 31, 2024
@scouten-adobe scouten-adobe marked this pull request as draft July 31, 2024 23:29
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 65.12262% with 128 lines in your changes missing coverage. Please review.

Project coverage is 76.67%. Comparing base (94d5b12) to head (2568ac5).
Report is 1 commits behind head on main.

Files Patch % Lines
src/w3c_vc/temp_cose.rs 37.14% 66 Missing ⚠️
src/w3c_vc/identity_assertion_vc.rs 38.46% 16 Missing ⚠️
src/identity_assertion/signer_payload.rs 73.21% 15 Missing ⚠️
src/identity_assertion/named_actor.rs 0.00% 12 Missing ⚠️
src/w3c_vc/cose_vc_signature_handler.rs 94.03% 9 Missing ⚠️
src/internal/naive_credential_handler.rs 0.00% 6 Missing ⚠️
src/identity_assertion/mod.rs 70.00% 3 Missing ⚠️
src/identity_assertion/validation_error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   87.32%   76.67%   -10.66%     
===========================================
  Files           9       15        +6     
  Lines         363      673      +310     
===========================================
+ Hits          317      516      +199     
- Misses         46      157      +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scouten-adobe added a commit that referenced this pull request Aug 13, 2024
(Will be needed in order to land #26.)
(See #27, which reminds me to add proper error handling.)
@scouten-adobe scouten-adobe mentioned this pull request Aug 14, 2024
scouten-adobe added a commit that referenced this pull request Aug 14, 2024
(Will be needed in order to land #26.)
@scouten-adobe scouten-adobe marked this pull request as ready for review August 14, 2024 17:15
(Why does Clippy find different things in CI than on my Mac?)
@scouten-adobe scouten-adobe changed the title Add VC support Add preliminary VC support Aug 14, 2024
@scouten-adobe scouten-adobe merged commit e90dc9e into main Aug 14, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant