Performance Fixes #99
Conversation
…nfiguration phase for multi-module projects with a lot of cross-references. 1. Loads the plugin just one time, instead of loading separately for each module. Debug logging showed that sometimes, this operations takes 10 sec (on some machines at least). 2. The more critical issue was in `recursiveDependenciesOf`. Without caching of the results, the same operations are repeated over and over again and it takes minutes to configure. For a work project I have, with 16 modules, with a lot of cross-references, adding the scoverage plugin without these fixes takes 5-10 mins. The worst of it is that this is the wait time for each change in any build.gradle (e.g. adding a new dependency), which makes the work nearly impossible. After applying the fixes, there is no significant difference with the time taken without the scoverage plugin.
|
@maiflai this is the first time I make PRs to this repo, so I don't know if I have to ping people or you get notifications on any proposed PRs anyway. |
|
Thanks very much - I'll try to take a look in the next couple of days. Stu |
|
@maiflai thanks for merging this! One hopefully last question. At what intervals do you push new versions to maven-repository? Do you have the practice of pushing updates like this one as minor versions e.g. 3.0.1 |
|
Sorry - this is normally pushed to maven central at the same time as the gradle plugin repository. However, I think something has changed at Sonatype because they now require a javadoc before it can be released. I seem to recall that this was relaxed for the groovy projects a while ago, I need to chase them for an answer. Stu |
|
Please, let me know when you have some answers. Appreciate it! |
|
I didn't read the error message properly - 'no javadoc' is the name of the profile, not a failed test. I've now managed to publish to maven central, 3.1.1 should be visible now. |
|
I can see 3.0.0 only just yet. https://mvnrepository.com/artifact/org.scoverage/gradle-scoverage It may take some time. |
|
@tpetrov-rms Thank you for the contribution :) I have a question though - when does the It is important that the map will reset on every build as there might be changes in those dependencies from build to build as project configuration changes. |
Two performance fixes without which the build takes minutes in the configuration phase for multi-module projects with a lot of cross-references.
Loads the plugin just one time, instead of loading separately for each module. Debug logging showed that sometimes, this operations takes 10 sec (on some machines at least).
The more critical issue was in
recursiveDependenciesOf. Without caching of the results, the same operations are repeated over and over again and it takes minutes to configure.For a work project I have, with 16 modules, with a lot of cross-references, adding the scoverage plugin without these fixes takes 5-10 mins. The worst of it is that this is the wait time for each change in any build.gradle (e.g. adding a new dependency), which makes the work nearly impossible. After applying the fixes, there is no significant difference with the time taken without the scoverage plugin.