Skip to content

Feature request: Scala 2.12 support #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holograph opened this issue Jul 23, 2015 · 15 comments
Closed

Feature request: Scala 2.12 support #126

holograph opened this issue Jul 23, 2015 · 15 comments

Comments

@holograph
Copy link

The title says it all, I think :-)

@sksamuel
Copy link
Member

Will definitely come once 2.12 is a bit more stable I think. The reason why is that the AST that the compiler generates might not be locked down yet and that's what the scoverage plugin has to manipulate.

@milessabin
Copy link

Can I bump this ... it's a blocker for shapeless adding support for Scoverage because our build matrix includes 2.12.0-M3 and there doesn't appear to be any straightforward way to load it for a subset of Scala versions.

@sksamuel
Copy link
Member

scoverage/scalac-scoverage-plugin#152
Better track it on the plugin itself, as it's not an sbt feature strictly speaking. I have a 2.12 build locally that is currently failing on 6 tests, so its on my radar this week or so to get those finished.

@sksamuel sksamuel reopened this Feb 28, 2016
@milessabin
Copy link

Gotcha ... thanks.

@everson
Copy link

everson commented Mar 6, 2016

@sksamuel We are trying to add scoverage to milessabin/shapeless and are currently blocked because current version of plugin always tries to load scala version specific runtime plugins. I see that this is fixed in master but there is no version released. Any plans to release it soon?

Btw, sorry about double posting, but it's been a few days already https://groups.google.com/forum/#!topic/scala-code-coverage-tool/OUiAS1EVmcQ

@sksamuel
Copy link
Member

sksamuel commented Mar 6, 2016

If its just a release you need I can do it later today.
On 6 Mar 2016 01:08, "Johnny Everson" notifications@github.com wrote:

@sksamuel https://github.com/sksamuel We are trying to add scoverage to
milessabin/shapeless and are currently blocked because current version of
plugin always tries to load scala version specific runtime plugins. I see
that this is fixed in master but there is no version released. Any plans to
release it soon?

Btw, sorry about double posting, but it's been a few days already
https://groups.google.com/forum/#!topic/scala-code-coverage-tool/OUiAS1EVmcQ


Reply to this email directly or view it on GitHub
#126 (comment)
.

@gslowikowski
Copy link
Member

I would like to test it before release. It's not even merged to master and you commented a week ago that there are still failing tests. Has something changed since then?

@sksamuel
Copy link
Member

sksamuel commented Mar 6, 2016

I think he's talking about the other issue, not 2.12 support, just happens
to be in this thread.

On 6 March 2016 at 10:40, Grzegorz Slowikowski notifications@github.com
wrote:

I would like to test it before release. It's not even merged to master and
you commented a week ago that there are still failing tests. Has something
changed since then?


Reply to this email directly or view it on GitHub
#126 (comment)
.

@gslowikowski
Copy link
Member

If it' about #153, your commit broke sbt-scoverage. I wrote about it.

@everson
Copy link

everson commented Mar 6, 2016

Oh yes. Sorry about not being clear. Yes, what I mean is that we cross compile to 2.12 and without #126 or #153 we cannot use scoverage plugin

@magicknot
Copy link

Any news on this?

@gslowikowski
Copy link
Member

See scoverage/scalac-scoverage-plugin#177 (comment).

@Facsimiler
Copy link

As Scala 2.12.0 was officially released today, do you have a schedule for releasing a compatible version of scoverage?

(Thanks for providing such a great tool, BTW!)

@gslowikowski
Copy link
Member

Version 1.5.0 with Scala 2.12 support released.

@tobyweston
Copy link

👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants