Skip to content

Make dataDir configurable #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
btomala opened this issue Sep 18, 2018 · 4 comments
Closed

Make dataDir configurable #261

btomala opened this issue Sep 18, 2018 · 4 comments

Comments

@btomala
Copy link

btomala commented Sep 18, 2018

I'm trying to run my integration tests in docker the problem is that the dataDir is set up as crossTarget.value which is taken from my local machine. Will be a lot of easier if this will be default but I can override this value.

@gslowikowski
Copy link
Member

How/where will you create reports after the tests? Still in docker?

@btomala
Copy link
Author

btomala commented Sep 23, 2018

  • I'm using DockerPlugin to build an image with instrumented code.
  • The dataDir is set to the directory, e.g. /tmp/my-app/coverage needs to be the same on the building machine and inside a docker image.
  • The coverage plugin generates there required files in dataDir, I add them to the Universal / mappings and docker plugin copy them into the docker image during the building process.
  • I deploy docker and run the integration tests.
  • I'm copying docker:/tmp/my-app/coverage to ci:/tmp/my-app/coverage and run sbt coverageReport on ci machine.

A workaround for this PR is to create a directory with the same path what crossTarget has during the compilation, inside the docker and give access to it for the user which starting application. But this is one of the configuration option exposed by scoverage-plugin and should be exposed to users.

@zabbal
Copy link

zabbal commented Mar 31, 2020

If I understand what dataDir is (the place where results of "sbt coverage test" are stored which will be needed for "sbt coverageReport") than I'm interested in this issue as well. It's very convenient to split generation of coverage data from generation of report based on that data. Having ability to explicitly configure intermediate storage for the data which have to be shared between those stage would greatly simplify things.

@ckipp01
Copy link
Member

ckipp01 commented Nov 4, 2021

This is now configurable in the more recent versions of sbt-scoverage.

@ckipp01 ckipp01 closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants