Skip to content

Add coverageScalacPluginVersion setting key #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2016
Merged

Add coverageScalacPluginVersion setting key #183

merged 2 commits into from
Sep 18, 2016

Conversation

lustefaniak
Copy link
Contributor

Make it easier to change version of scalac-scoverage-plugin dependency

@lustefaniak
Add coverageScalacPluginVersion setting key
e0e2be6 
Make it easier to change version of scalac-scoverage-plugin dependency
@gslowikowski
Copy link
Member

You forgot to change DefaultScoverageVersion to coverageScalacPluginVersion in projectSettings (libraryDependencies ++= ... section).

@lustefaniak
Copy link
Contributor Author

@gslowikowski Thanks, I was already pushing fixed version ;)

@gslowikowski
Copy link
Member

:)

@gslowikowski
Copy link
Member

LGTM, can I merge it?

@lustefaniak
Copy link
Contributor Author

RDY, I added one scripted test to assert correct behaviour

@gslowikowski gslowikowski merged commit b6a6d22 into scoverage:master Sep 18, 2016
@lustefaniak lustefaniak deleted the scoverage-scalac-plugin-version-support branch September 18, 2016 19:00
@lustefaniak lustefaniak mentioned this pull request Sep 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lustefaniak @gslowikowski