Add support for scala.js runtime

[lustefaniak]

No description provided.

[gslowikowski]

Ready to merge?

[lustefaniak]

RDY, I tested it locally and scala.js works perfectly.
It fails for me on scripted scoverage/aggregate, but that is also failing on master I think check script misses coverageReport which is not executed after test anymore (and I think in the past it was not needed).

[lustefaniak]

Would be great to have scripted tests execute on Travis, I will fix that scripted scoverage/aggregate in next PR.

[gslowikowski]

OK

[gslowikowski]

Some time ago we discussed on Gitter and here about adding sbt-scalajs plugin and using %%% operator.

In Play! Framework Twirl module they went this way: playframework/twirl@104128a (look at build.sbt changes).

[lustefaniak]

Can you please explain what you mean? I think I don't undertand, do you mean adding addSbtPlugin in build? That doesn't solve the problem at all, as operator %%% used in that context has completly different meaning than operator used in user project (eg. different versions)

[gslowikowski]

We talked about using:

        OrgScoverage %%% ScalacRuntimeArtifact % coverageScalacPluginVersion.value,

instead of

        OrgScoverage %% (ScalacRuntimeArtifact + optionalScalaJsSuffix(libraryDependencies.value)) % coverageScalacPluginVersion.value,

here

[lustefaniak]

Yes, but that approach would still require pulling in sbt-scalajs plugin. I checked its source code and there is nothing we could reuse, everything depends on hardcoded scala.js binary version.

[lustefaniak]

Hi @sjrd can you please confirm if such approach should support future version of scala.js? Or how we could improve that without adding sbt-scalajs to dependencies?

[sjrd]

It will work as long as we're in the 0.6.x series. When we switch to the 1.x.y series, the binary _sjs version will be only the major version, so _sjs1 (and not _sjs1.0).