Skip to content

Fix #440 #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix #440 #441

wants to merge 3 commits into from

Conversation

guizmaii
Copy link

Fixes #440

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @guizmaii! I added a commit on top just to ensure that CI would run and also added windows into the CI to see if we could verify this is working. It seems to still have issues:

[info] [error] bad option: -P:scoverage:dataDir:C:\Users\runneradmin\AppData\Local\Temp\sbt_50e0e1f6\partB\target\scala-2.13\scoverage-data
[info] [error] bad option: -P:scoverage:sourceRoot:C:\Users\runneradmin\AppData\Local\Temp\sbt_50e0e1f6
[info] [error] bad option: -P:scoverage:reportTestName
[info] [error] bad option: -P:scoverage:dataDir:C:\Users\runneradmin\AppData\Local\Temp\sbt_50e0e1f6\partA\target\scala-2.13\scoverage-data
[info] [error] bad option: -P:scoverage:sourceRoot:C:\Users\runneradmin\AppData\Local\Temp\sbt_50e0e1f6
[info] [error] bad option: -P:scoverage:reportTestName

@guizmaii
Copy link
Author

@ckipp01 Thank you for your help 🙇

I'll have a look at the issue later today

@guizmaii
Copy link
Author

I had a look. It seems to be more complicated than I expected.
The time for me to find the issue would be probably more than I can afford to spend, sadly.

I close the PR, hoping that someone will be able to tackle the issue.

@guizmaii guizmaii closed this Jun 28, 2022
@guizmaii guizmaii deleted the fix_440 branch June 28, 2022 19:44
@ckipp01
Copy link
Member

ckipp01 commented Jun 29, 2022

No worries, thanks for raising the issue!

@nafg
Copy link

nafg commented Aug 15, 2022

@guizmaii can you share your analysis of the cause, and what the complexity and challenge is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sbt-scoverage 2.0.0 fails on Windows with [error] bad option: -P:scoverage: errors
3 participants