Added the ability to disable coverage data recording at run-time #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VM property `scoverage.recording.enabled` to `false` Slight optimization of runtime
|
This could be merged, but I think its dangerous to have instrumentation in real deployables. Is there a useful for that? |
|
Our use-case was that during development we would run integration tests within docker, where the baked-in coverage data directories do not exists. We wanted to avoid constantly building everything twice. It is both difficult to manage two such configurations, and time consuming to perform the builds. So we opted to always build with coverage instrumentation during development, and find a way to disable the coverage at run-time for integration tests. For the real deployables, before we publish the artifacts, we did rebuild everything with coverageOff. |
gslowikowski
added a commit
to scoverage/sbt-scoverage
that referenced
this pull request
Sep 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to disable coverage data recording by setting the JVM property
scoverage.recording.enabledtofalse(needed to run the instrumented code onother machines such as docker containers).
Slight optimization of runtime