Skip to content

Restored the ability to enable coverage with coverageEnabled #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2016

Conversation

patrick-premont
Copy link

Restored the ability to enable coverage within the project description with coverageEnabled.

Made the libraryDependencies setting depend on coverageEnabled, so as to simplify the implementation of the coverage command.

Runtime is no longer just a 'provided' dependency of a coverage-enabled project.

…n with coverageEnabled.

Made the libraryDependencies setting depend on coverageEnabled, so as to simplify the implementation of the coverage command.

Runtime is no longer just a 'provided' dependency of a coverage-enabled project.
@patrick-premont
Copy link
Author

Documentation changes depend on plugin PR scoverage/scalac-scoverage-plugin#162

@gslowikowski
Copy link
Member

I've tested your PR with sequences like:
sbt clean coverage publishLocal
sbt clean coverage compile coverageOff publishLocal
sbt clean coverage compile coverageOff compile coverage publishLocal
and it seems to work properly. Instrumented/uninstrumented classes in jar file and scalac-scoverage-runtime dependency present/absent in published ivy/pom file.

Can you tell me, how it works and if this is recommended way to toggle dependencies dynamically or your idea? Maybe some links? Thanks.

BTW.
It's good that you removed provided scope. If for some reason (or accidentally) instrumented classes will be deployed, scalac-scoverage-runtime dependency should be active in run time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants