Using coverage/coverageOff preserves settings overrides #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses the issue #146 .
The problem was that the method
Extracted.append
actually drops the settings that were added with theset
command.You can see it here: https://github.com/sbt/sbt/blob/1.0.x/main/src/main/scala/sbt/Extracted.scala#L105
session.original
is used instead ofsession.mergeSettings
.Instead of using
Extracted.append
I usedSessionSettings.reapply
.I added a scripted test to check that
coverage
andcoverageOff
do not reset settings set withset
.When running the scripted tests, aggregate was failing because a call to
coverageReport
was missing (according to https://github.com/scoverage/sbt-scoverage#multi-project-reports).Also, coverage-off is failing because of 0f9496d , but it should be fixed by PR #166 or PR #168.