-
Notifications
You must be signed in to change notification settings - Fork 159
coverage resets a manually set scalaVersion #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ouch thats nasty. private def toggleCoverage(status:Boolean): State => State = { state =>
val extracted = Project.extract(state)
val newSettings = extracted.structure.allProjectRefs map { proj =>
coverageEnabled in proj := status
}
extracted.append(newSettings, state)
} Which is setting the coverageEnabled flag for each project to true. I'm guessing there is a misunderstanding of how/what this code is doing. |
I understand scala 2.10 support was dropped in scoverage. |
Yes it was (was always patchy due to range position stuff). On 8 April 2016 at 07:40, Sam Halliday notifications@github.com wrote:
|
This issue is unrelated to the dropped 2.10 support: > ++2.11.7
[info] Setting version to 2.11.7
[info] Reapplying settings...
[info] Set current project to refined (in build file:/home/frank/data/code/refined/)
> coreJVM/scalaVersion
[info] 2.11.7
> coverage
[info] Set current project to refined (in build file:/home/frank/data/code/refined/)
> coreJVM/scalaVersion
[info] 2.11.8 Just tested this with version 1.3.5. |
Problem This commit causes downstream projects to fail as the autoplugin mechanism for the scoverage plugin is wreaking havoc when downstream projects: ostrich, scrooge and finatra try to run their tests. FileNotFoundExceptions are generated (the scoverage Invoker is getting run during tests which fails due to no coverage data being available at that time). An example failure: https://s3.amazonaws.com/archive.travis-ci.org/jobs/135689956/log.txt Additionally upgrading to scoverage plugin version 1.3.5 does not work with TravisCI because of these issues: scoverage/sbt-scoverage#161 scoverage/sbt-scoverage#146 Which caused us to back out of upgrading to scoverage 1.3.5 previously. The odd thing is that util built fine with these changes, unfortunately the downstream projects did not. Solution Revert commit, RB 837525 and update the .travis.yml. Result Downstream projects no longer fail to build. RB_ID=839869
See scoverage/sbt-scoverage#146 (coverage resets a manually set scalaVersion)
This is fixed in 1.4.0, right? |
Right. |
Fixed by #186 |
With sbt-scoverage 1.3.3 this happens in my project:
Calling coverage should not change
scalaVersion
. I first noticed this issue here fthomas/refined#72.The text was updated successfully, but these errors were encountered: