Revert sbt-scoverage #571
Merged
Revert sbt-scoverage #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
Thanks @travisbrown! Please, don't worry about that! I totally don't mind those extra types in the Thanks again for taking a time and fixing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I made a kind of annoying mistake last week.
Last fall I updated circe to sbt-scoverage 1.3.3, ran into a terrible bug that meant the 2.10 builds weren't running, and then reverted the update back to sbt-scoverage 1.2.0.
Last week I forgot entirely about this, saw that sbt-scoverage 1.3.5 was out, and updated both circe and Finch, without confirming that the bug (scoverage/sbt-scoverage#146) had been fixed. In fact I'd forgotten about the bug entirely.
This means that since 81d89e2 Travis CI hasn't been running 2.10 builds for Finch. Which wouldn't necessarily be a big deal, but some of the new content type stuff doesn't work on 2.10—or rather it works, but requires explicit type annotations.
I still don't think this is a terribly big deal. Lots of projects (like Play) are already dropping 2.10 support altogether, and we could provide helper methods if maintaining first-class 2.10 support is a priority here.
I've switched back to sbt-scoverage and added the type annotations to make the tests compile on 2.10. Sorry about this—I should have remembered the problem and been more careful.