Skip to content

Using coverage/coverageOff preserves settings overrides #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/scala/scoverage/ScoverageSbtPlugin.scala
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ object ScoverageSbtPlugin extends AutoPlugin {
*/
private def toggleCoverage(status: Boolean): State => State = { state =>
val extracted = Project.extract(state)
val currentProjRef = extracted.currentRef
val newSettings = extracted.structure.allProjectRefs flatMap { proj =>
Seq(
coverageEnabled in proj := status,
Expand All @@ -60,7 +61,9 @@ object ScoverageSbtPlugin extends AutoPlugin {
}
)
}
extracted.append(newSettings, state)
val appendSettings = Load.transformSettings(Load.projectScope(currentProjRef), currentProjRef.build, extracted.rootProject, newSettings)
val newSessionSettings = extracted.session.appendRaw(appendSettings)
SessionSettings.reapply(newSessionSettings, state)
}

private lazy val coverageReport0 = Def.task {
Expand Down
6 changes: 5 additions & 1 deletion src/sbt-test/scoverage/aggregate/test
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
# There should be scoverage-data directory
$ exists partA/target/scala-2.10/scoverage-data
$ exists partB/target/scala-2.10/scoverage-data
> coverageReport
# There should be scoverage-report directory
$ exists partA/target/scala-2.10/scoverage-report
$ exists partB/target/scala-2.10/scoverage-report
> coverageAggregate
# There should be scoverage-data directory
# There should be a root scoverage-report directory
$ exists target/scala-2.10/scoverage-report
14 changes: 14 additions & 0 deletions src/sbt-test/scoverage/preserve-set/build.sbt
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import sbt.complete.DefaultParsers._

version := "0.1"

scalaVersion := "2.10.4"

libraryDependencies += "org.specs2" %% "specs2" % "2.3.13" % "test"

val checkScalaVersion = inputKey[Unit]("Input task to compare the value of scalaVersion setting with a given input.")
checkScalaVersion := {
val arg: String = (Space ~> StringBasic).parsed
if (scalaVersion.value != arg) error(s"scalaVersion [${scalaVersion.value}] not equal to expected [$arg]")
()
}
15 changes: 15 additions & 0 deletions src/sbt-test/scoverage/preserve-set/project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// The Typesafe repository
resolvers += "Typesafe repository" at "http://repo.typesafe.com/typesafe/releases/"

//scoverage needs this
resolvers += Classpaths.sbtPluginReleases

{
val pluginVersion = System.getProperty("plugin.version")
if(pluginVersion == null)
throw new RuntimeException("""|The system property 'plugin.version' is not defined.
|Specify this property using the scriptedLaunchOpts -D.""".stripMargin)
else addSbtPlugin("org.scoverage" %% "sbt-scoverage" % pluginVersion)
}


Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
object PreserveSet {

def sum(num1: Int, num2: Int) = {
num1 + num2
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import org.specs2.mutable._

class PreserveSetSpec extends Specification {

"PreserveSet" should {
"sum two numbers" in {
PreserveSet.sum(1, 2) mustEqual 3
}
}
}
11 changes: 11 additions & 0 deletions src/sbt-test/scoverage/preserve-set/test
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# check scalaVersion setting
> checkScalaVersion "2.10.4"
# override scalaVersion setting
> set scalaVersion := {"2.10.5"}
> checkScalaVersion "2.10.5"
# activate coverage - override should still be present
> coverage
> checkScalaVersion "2.10.5"
# turn off coverage - override should still be present
> coverageOff
> checkScalaVersion "2.10.5"