Ensure js artifact has sjs preface #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
commented
Apr 27, 2021
build.sbt
Outdated
| @@ -83,6 +83,7 @@ lazy val runtime = CrossProject("scalac-scoverage-runtime", file("scalac-scovera | |||
| fork in Test := true | |||
| ) | |||
| .jsSettings( | |||
| name := name.value + "_s" + crossProjectPlatform.value.identifier, | |||
There was a problem hiding this comment.
Yea this won't work either actually...
Because we are doing a full cross release here, that means in the sbt plugin we also need to target it like so:
When doing this. during the js tests it will then fail since it'll be looking for _sjs1.0_2.12-1.4.3-SNAPSHOT.
not found: /Users/ckipp/.ivy2/local/org.scoverage/scalac-scoverage-runtime_sjs1.0_2.12/1.4.3-SNAPSHOT/ivys/ivy.xml
It's odd because it seems that doing the full cross release and the js stuff here together is really screwing with things as it's now looking for the full scalajs version instead of the fully binary Scala version. I don't fully get what's going on here.
|
Closing in favor of #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #305