updated sbt to 1.5.1, updated deprecated 0.13 config style

[domizei385]

hopefully fix sjs artifact name

[ckipp01]

Thanks for the pr @domizei385! Let me verify this locally with the sbt plugin, but this looks good.

[ckipp01]

Everything seems to be working fine when testing the sbt plugins, except for the js tests

[info] [info] Fast optimizing /private/var/folders/fq/nx_jsnyd6550xp03czx898d40000gn/T/sbt_e9fa5735/sjstest/js/target/scala-2.12/sjstest-test-fastopt
[info] [error] Referring to non-existent class scoverage.Invoker$
[info] [error]   called from UnderTest$.onJsAndJvm()java.lang.String
[info] [error]   called from private SharedTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor SharedTest.<init>()void
[info] [error]   called from static constructor SharedTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Referring to non-existent class scoverage.Invoker$
[info] [error]   called from UnderTest$.onJsAndJvm()java.lang.String
[info] [error]   called from private SharedTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor SharedTest.<init>()void
[info] [error]   called from static constructor SharedTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Referring to non-existent method scoverage.Invoker$.invoked$default$3()boolean
[info] [error]   called from UnderTest$.onJsAndJvm()java.lang.String
[info] [error]   called from private SharedTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor SharedTest.<init>()void
[info] [error]   called from static constructor SharedTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Referring to non-existent method scoverage.Invoker$.invoked(int,java.lang.String,boolean)void
[info] [error]   called from UnderTest$.onJsAndJvm()java.lang.String
[info] [error]   called from private SharedTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor SharedTest.<init>()void
[info] [error]   called from static constructor SharedTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Referring to non-existent class scoverage.Invoker$
[info] [error]   called from UnderTest$.jsMethod()java.lang.String
[info] [error]   called from private JsTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor JsTest.<init>()void
[info] [error]   called from static constructor JsTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Cannot access module for non-module scoverage.Invoker$
[info] [error]   called from UnderTest$.jsMethod()java.lang.String
[info] [error]   called from private JsTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor JsTest.<init>()void
[info] [error]   called from static constructor JsTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Referring to non-existent class scoverage.Invoker$
[info] [error]   called from UnderTest$.jsMethod()java.lang.String
[info] [error]   called from private JsTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor JsTest.<init>()void
[info] [error]   called from static constructor JsTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Referring to non-existent class scoverage.Invoker$
[info] [error]   called from UnderTest$.jsMethod()java.lang.String
[info] [error]   called from private JsTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor JsTest.<init>()void
[info] [error]   called from static constructor JsTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Referring to non-existent class scoverage.Invoker$
[info] [error]   called from UnderTest$.onJsAndJvm()java.lang.String
[info] [error]   called from private SharedTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor SharedTest.<init>()void
[info] [error]   called from static constructor SharedTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] Cannot access module for non-module scoverage.Invoker$
[info] [error]   called from UnderTest$.onJsAndJvm()java.lang.String
[info] [error]   called from private SharedTest.$anonfun$new$1()org.scalatest.compatible.Assertion
[info] [error]   called from constructor SharedTest.<init>()void
[info] [error]   called from static constructor SharedTest.<stinit>()void
[info] [error]   called from core module analyzer
[info] [error] involving instantiated classes:
[info] [error]   UnderTest$
[info] [error] There were linking errors
[info] [error] (sjstestJS / Test / fastLinkJS) There were linking errors
[info] [error] Total time: 14 s, completed 27 Apr 2021, 19:30:43
[error] x scoverage/scalajs
[error]  Cause of test exception: {line 4}  Command failed: test failed

Any ideas?

[domizei385]

Not yet. Will check later tonight. Unless you beat me to it.

[ckipp01]

Not yet. Will check later tonight. Unless you beat me to it.

Sounds good. I'll see if I can figure it out. If not, I'll push up a branch to the sbt plugin repo and tag you on it.

[domizei385]

Okay. Locally I got all tests to work, but I have messed with the plugin quite a lot (when I was creating a build for my customer to support 2.12.13) so I need to prepare it before I can create a public PR.
@ckipp01 Do you also have write access to the sbt plugin repo?

[ckipp01]

Okay. Locally I got all tests to work, but I have messed with the plugin quite a lot (when I was creating a build for my customer to support 2.12.13) so I need to prepare it before I can create a public PR.
@ckipp01 Do you also have write access to the sbt plugin repo?

Yes I do. I have a pr sent up there that has everything passing but the js tests.

[domizei385]

👍 I’ll create the PR in a few hours. Then we can cherry pick the best pieces from both PRs.

[domizei385]

Please see scoverage/sbt-scoverage#324 for related sbt plugin PR

[ckipp01]

Just a quick question on Scala js but other than that, LGTM

[ckipp01]

Actually I just got some clarification that the sjs1.5 isn't a thing, so we'll need to switch this to just be sjs1.

[ckipp01]

Alright verified that all is working locally now with _sjs1.