fix: ignore lazy definition generated from by-name implicits #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleontiev
force-pushed
the
ignore-lazy-defs-from-by-name-implicits
branch
from
51f4004 to
a0588cd
Compare
Preamble: by-name implicit parameters used for shapeless magic and were introduced in SIP-31 (available from 2.13+): https://docs.scala-lang.org/sips/byname-implicits.html Using scoverage with such code may result in the following warning from the plugin: [warn] Could not instrument [Select/value rec$1]. Originally discovered by using scoverage with the code that derives typeclass instances using kittens library: case class Bar() case class Foo(bars: List[Bar]) object Foo { implicit eq: cats.Eq[Foo] = cats.derived.semiauto.eq } Solution: Ignore LazyDefns$1.rec$1 from instrumentation like other synthetic code Other changes: It was necessary to disable position validation phase for the test case that reproduces the issue because the code generated by scala compiler fails such validation. It could be also checked outside testing environment by manually setting -Yvalidate-pos:typer option to the compiler. Not sure whether it's expected compiler behavior or not
danielleontiev
force-pushed
the
ignore-lazy-defs-from-by-name-implicits
branch
from
a0588cd to
8382a62
Compare
ckipp01
approved these changes
Mar 10, 2023
Member
ckipp01
left a comment
ckipp01
left a comment
There was a problem hiding this comment.
Thanks for this @danielleontiev! And thanks for the explanations. Regarding the position validation behavior, to be honest I'm not really sure what's happening there. However all tests are passing so I'm pretty comfortable merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preamble:
by-name implicit parameters used for shapeless magic and were introduced in SIP-31 (available from 2.13+):
https://docs.scala-lang.org/sips/byname-implicits.html
Using scoverage with such code may result in the following warning from the plugin:
Originally discovered by using scoverage with the code that derives typeclass instances using kittens library:
Solution:
Ignore
LazyDefns$1.rec$1from instrumentation like other synthetic codeOther changes:
It was necessary to disable position validation phase for the test case that reproduces the issue because the code generated by scala compiler fails such validation. It could be also checked outside testing environment by manually setting
-Yvalidate-pos:typeroption to the compiler. Not sure whether it's expected compiler behavior or not