Don't compile main sources in scoverage lifecycle when skip is set
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozic
force-pushed
the
dont-compile-main-when-skip
branch
from
806d4ae
to
be63034
Compare
|
@justinplus please check it out, that's what you wanted to achieve in #178, right? It's interesting that according to git, this line in PreCompile mojo used to be there at some point but was dropped later. Not sure if this is gonna cause any issues, but all the tests pass so far. |
jozic
force-pushed
the
dont-compile-main-when-skip
branch
2 times, most recently
from
ed76ed4
to
4912e47
Compare
jozic
force-pushed
the
dont-compile-main-when-skip
branch
from
4912e47
to
bf84b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Explain the why of this pull request.
Checklist