Increase mobile breakpoint #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossjrw
force-pushed
the
increase-breakpoint
branch
from
8223f9d
to
c1bc2f7
Compare
rossjrw
force-pushed
the
increase-breakpoint
branch
from
48949eb
to
fe6f0ff
Compare
emmiegit
approved these changes
Dec 18, 2020
| transition: left .5s ease-in-out .1s; | ||
| } | ||
|
|
||
| /* XXX What is this for? */ |
There was a problem hiding this comment.
Change to TODO? XXX should be for development, not added to master.
| } | ||
|
|
||
| /* When the sidebar is the URL target, move it to the right */ | ||
| #side-bar:target { |
There was a problem hiding this comment.
Add a comment explaining that this is why we have the page#side-bar addition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to this thread, this is a PR to increase the breakpoint for the sidebar to 1024px.
There are four media queries at four different breakpoints that target the sidebar and its button. The first three breakpoints are subsets of the last, and the properties set in the last override those of the previous ones, so I've straight-up removed the superfluous queries. I've also split the out the sidebar styling from the big 767px query at the end into its own one, which I've placed at the bottom of the sidebar section - this will probably the first step of a larger rework, eventually, to break down the stylesheet into different sections and possibly different files.
Because the mobile topbar contains the link that opens the sidebar, I've moved it to the same breakpoint.
This PR should not be merged if and until the new breakpoint has been agreed upon.