Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Events that take place on several days not appear when we click on the first day #434

Closed
scraly opened this issue Apr 22, 2023 · 2 comments
Labels

Comments

@scraly
Copy link
Owner

scraly commented Apr 22, 2023

I tested with one event in december "DevTernity" that will take place the 7 & 8, I see the event if I click on the 8 but not if I click on the 7:
image

image

@scraly scraly added the bug label Apr 22, 2023
@Damien-VS
Copy link
Contributor

Damien-VS commented Apr 24, 2023

PR : #436

⚠️ The fix from Gouz (commit b891595) will still have shifted events depending on the timezone / timeshifting scheme between

  • the client browser at rendering time
  • the CI parsing events into timestamps at build time

Which causes the bug in the first place. (github in GMT, Aurelie & I in GMT+1).
Building / browsing the site in a different timezone is a nice way of testing this behaviour

@scraly scraly closed this as completed in 0c0c6dc Apr 24, 2023
@scraly
Copy link
Owner Author

scraly commented Apr 24, 2023

Thanks, I will put your code @Damien-VS in the new code :)

scraly added a commit that referenced this issue Apr 24, 2023
scraly added a commit that referenced this issue Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants