Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish ics as static ressources #464

Merged
merged 3 commits into from
May 9, 2023
Merged

feat: publish ics as static ressources #464

merged 3 commits into from
May 9, 2023

Conversation

sylvainmetayer
Copy link
Contributor

@sylvainmetayer sylvainmetayer commented May 3, 2023

Add a build script to generate ICS files (one per year) at build time containing all events.

To test it :

cd page
npm install -D --force

cd ../tools
node mdValidator.js
node mdParser.js
node generateIcs.js

cd ../page
npm run build

cd build
cp ../src/misc/*.ics .
npx serve

Note : I don't know React enough to make generated ICS files work in development mode (as it is located in a different folder), however, it seems to be working when building production assets, as described above. If you have any hints on what is missing, I'd appreciate some feedback :)

@sylvainmetayer sylvainmetayer marked this pull request as ready for review May 4, 2023 11:33
Copy link
Owner

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
thanks for the PR.

In page/src/styles/App.css file, in .downloadButton css block, add:

text-decoration: none;
color: black;

In order to fix the download button style.

@sylvainmetayer
Copy link
Contributor Author

I've updated the component style

@scraly scraly added the 1.0.3 label May 9, 2023
@scraly
Copy link
Owner

scraly commented May 9, 2023

thanks :)
fix #295

@scraly scraly merged commit d11bf8c into scraly:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants