feat: add event cont for day, month and year #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scraly
requested changes
Jul 28, 2023
|
@gouz can you review the PR please? :) |
gouz
reviewed
Jul 28, 2023
|
Hi @edouard-lopez and @Farsen976 thanks for your contributions ❤️ |
gouz
approved these changes
Aug 1, 2023
| return `${count} events` | ||
| const getCountText = (count) => { | ||
| if (count) { | ||
| const plural = count > 1 ? "s" : "" |
There was a problem hiding this comment.
const plural = count > 1 ? "s" : "";
There was a problem hiding this comment.
I run prettrier on the file
scraly
requested changes
Aug 1, 2023
| @@ -0,0 +1,14 @@ | |||
| const getCountText = (count) => { | |||
| const getCountText = (count) => { | |||
There was a problem hiding this comment.
Is it normal these two lines const getCountText = (count) => {?
There was a problem hiding this comment.
nope, I'm testing GitHub codespace, must I messed up something. If you want to test it, you need to serve the app with to avoir 502 Bad Gateway error:
npm run dev -- --host 0.0.0.0
|
Thanks, for me now it's top! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result of contributing session with @Farsen976
<EventCount />component that take a list of events<SelectedEvents>and<YearSelector>to use<EventCount/>event.count.webm