Run release tests with parallel option #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
force-pushed
the
tests/parallel-2
branch
4 times, most recently
from
4222bf4 to
b70e71b
Compare
f1ames
requested review from
patuwwy,
daro1337,
a-tylenda,
alicja-gruzdz and
MichalCz
f1ames
changed the title
|
|
MichalCz
approved these changes
Mar 8, 2022
|
Rebased onto latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--parallel 2flag to "release tests" run on CI. I also had to get rid of "global"lets in CLI test steps (it still needs a proper cleanup but I wasn't focusing on that 🙈). After few runs it seems like tests are stable.OTOH, I tried to do the same with "dev tests" and there was always something failing, kind of randomly. So it looks like we need to clean up and rework those tests a bit to make it run with
--paralleloption.Good news - release tests instead of usual 7 to 9 minutes:
now are done in around 5 minutes:
Bad news - due to issue with mixed up logs, for parallel run I changed formatter to
progresswhich means it might be harder to conclude something (when test fails) looking on CI output, because there will be no steps (or if enabled, it will be mixed up).