-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The emitter opengraph produces rigid, fragile structures #153
Comments
@boxabirds that's a good question. The output with |
Uniform =true great I’ll try that thanks!
…On Wed, 9 Sep 2020 at 07:03, Konstantin Lopuhin ***@***.***> wrote:
@boxabirds <https://github.com/boxabirds> that's a good question. The
output with uniform=True is already a dict like you describe:
https://github.com/scrapinghub/extruct#uniform - so my understanding is
that by default we do minimal post-processing, but also provide the data in
a more convenient format.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#153 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABD62PEAJICV22EAOHN7CLSE4LDTANCNFSM4RAQUSHA>
.
|
So maybe we could update the docs so it emphasises that the uniform=True flag should be used in most new cases. I'd encourage the default to be this but that'd likely break your current users. |
OpenGraph has arrays and elements where order between tags matters: https://ogp.me/#array Is this covered? |
Consider this HTML construct:
This is turned into the following by the opengraph module:
Does anyone know why this couldn't instead be:
A case for having the output be this way:
["og:title"]
vs[1]
)og:tag
then I think this is a bug, certainly for the purposes ofextruct
. Or maybe I'm wrong on this.Thoughts most welcome.
The text was updated successfully, but these errors were encountered: