fixing crash on settings import when kafka-python isn't installed #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibiryakov
force-pushed
the
fix-import-crash
branch
from
d19f1c9
to
c674254
Compare
Current coverage is 47.63%@@ master #174 diff @@
==========================================
Files 72 72
Lines 4453 4465 +12
Methods 0 0
Messages 0 0
Branches 518 522 +4
==========================================
- Hits 2130 2127 -3
- Misses 2244 2258 +14
- Partials 79 80 +1
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#173