-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new parse_fraction function for simple fractions added with test data #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 98.70% 98.78% +0.07%
==========================================
Files 85 86 +1
Lines 309 328 +19
Branches 55 60 +5
==========================================
+ Hits 305 324 +19
Misses 1 1
Partials 3 3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a mention in the README?
Thanks, I have included a few examples in the README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment we have an introductory paragraph for the Usage section that mentions 3 interfaces, followed by 4 numbered interface sections.
I think it may be best to remove that paragraph, and rename those sections to something like:
- Converting numbers in-place
- Parsing a number
- Parsing an ordinal
- Parsing a fraction
adding bullets in readme and changing introductory paragraph
Renaming the sections is good, also I have changed the introductory paragraph a little in the usage section. Let me know if it's ok or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor wording issues, and I think this is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Will there be any other checks before merging this pull request? |
Let’s wait for @noviluni to find some time to review this as well. If he finds the changes OK as well, we’ll merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Manish-210 Good job! 🚀
Sorry for my late review. I really like the approach you used and I think it will be really useful. Thanks for updating the README too.
I added some notes, let me know once you address them and I will proceed with merging this 😄
Thanks, @noviluni, let me know any other changes. |
Thanks @Manish-210! 😄 |
See issue #59
parse_fraction function handles basic fraction.
Some test data has also been added.
Resolves #59