Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UnicodeDecode and AssertionError in tests #72

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Fixed UnicodeDecode and AssertionError in tests #72

merged 1 commit into from
Dec 31, 2021

Conversation

dhananjaypai08
Copy link
Contributor

@dhananjaypai08 dhananjaypai08 commented Dec 24, 2021

Closes #66
Set the encoding to "utf8" while opening a csv_file in the tests causing 2 AssertionErrors and 4 UnicodeDecode Errors while testing on Windows.

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #72 (ca28604) into master (c834854) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          86       86           
  Lines         328      328           
  Branches       60       61    +1     
=======================================
  Hits          324      324           
  Misses          1        1           
  Partials        3        3           

@Gallaecio
Copy link
Member

Thanks!

@Gallaecio Gallaecio merged commit 8367865 into scrapinghub:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode error in pytest for Hindi, Spansish and Russian in Windows.
2 participants