-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __version__ #87
Add __version__ #87
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 99.09% 99.10% +0.01%
==========================================
Files 85 86 +1
Lines 331 335 +4
Branches 60 60
==========================================
+ Hits 328 332 +4
Misses 1 1
Partials 2 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
That said:
- It feels weird to have 2 almost-identical, same-name functions.
- I find the approach from Scrapy slightly better, in that it makes me less uneasy to read the version from a file that only contains the version, and not from a file that contains more stuff.
- https://github.com/scrapy/scrapy/blob/b337c986ca1188f4b26d30c9ae4bb7ff457ed505/setup.py#L7
- https://github.com/scrapy/scrapy/blob/master/scrapy/VERSION
- https://github.com/scrapy/scrapy/blob/b337c986ca1188f4b26d30c9ae4bb7ff457ed505/scrapy/__init__.py#L31
- https://github.com/scrapy/scrapy/blob/b337c986ca1188f4b26d30c9ae4bb7ff457ed505/.bumpversion.cfg#L7
setup.py
Outdated
+ open("CHANGES.rst").read(), | ||
author="Arnav Kapoor", | ||
author_email="arnavk805@gmail.com", | ||
url="https://github.com/arnavkapoor/number-parser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the author and author_email should probably stay unless @arnavkapoor decides otherwise, we should probably update the URL.
5392c55
to
8fd3ed1
Compare
Close #86
Close #86