Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to change to rtm.connect() ? #209

Closed
a0149659 opened this issue Feb 15, 2020 · 5 comments · May be fixed by #229
Closed

Any plan to change to rtm.connect() ? #209

a0149659 opened this issue Feb 15, 2020 · 5 comments · May be fixed by #229

Comments

@a0149659
Copy link

I used this bot for a while, its an awesome project, however not usable with Slack Enterprise as it requires rtm.connect()

@a0149659
Copy link
Author

Thank you for your hard work @lins05 I really enjoyed your slackbot.

@lucywang000
Copy link
Collaborator

can you explain a bit about rtm.connect ?

@a0149659
Copy link
Author

a0149659 commented Feb 17, 2020

@lucywang000 Slackbot uses rtm.start() to initiate the slack.com API. Which gathers a bunch of info upon start, this is fine for basic workspaces. However for Enterprise Workspaces rtm.start is not allowed and rtm.connect is recommended by slack, which is more specific in regards of the information the bot its requesting. Causing slackbot to get a 500 error when attempting to connect to an Enterprise workspace. Here's slack's doc on it https://api.slack.com/rtm#connecting_with_rtm.connect_vs._rtm.start

Ive tried to change rtm.start to rtm.connect, and it connects to slack, but there's some user, channel, group, etc parsing that needs quite a bit of polishing up.

@hemna
Copy link

hemna commented Nov 18, 2020

Should switch over to using slack_sdk for talking to the slack API.
https://github.com/slackapi/python-slack-sdk

@lins05
Copy link
Collaborator

lins05 commented Sep 28, 2022

Thanks all for the discussion. This is fixed in bfdbef9.

@lins05 lins05 closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants