-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from slacker to slack-sdk #228
Conversation
+1 |
@jacobtruman this is promising. I tested it with my own bot and encountered an issue though: the bot enters an infinite loop due to rtm websocket disconnect:
Should we look into using the RTMClient instead? |
@amuraru good catch - is this something easily duplicated, so that I can properly test it? |
@amuraru I was able to duplicate this issue and added a ping to the parse user and channel data methods to prevent websocket disconnect. I am looking into implementing using RTMClient, but it looks like it might be a pretty hefty rewrite - I still think it is a good idea and am still experimenting with it. |
closing in favor of #229 under feature branch |
A newly created legacy bot token fails to authenticate using the older auth method used by the
slacker
module. Thertm.start
method has also been deprecated, so migrated tortm.connect
. Theslack-sdk
module also provides blocks support.Resolves #227.
Resolves #210.
Resolves #209.