Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dep on slack-sdk #363

Closed
wRAR opened this issue Sep 13, 2022 · 1 comment · Fixed by #367
Closed

No dep on slack-sdk #363

wRAR opened this issue Sep 13, 2022 · 1 comment · Fixed by #367

Comments

@wRAR
Copy link
Member

wRAR commented Sep 13, 2022

In #338 slackclient was replaced by slack-sdk in setup.py only in test_requirements but not in extras_require, so installing spidermon[monitoring] doesn't install it and the Slack action no longer works.

@rennerocha
Copy link
Collaborator

As a fallback, installing slack-sdk manually using pip install slack-sdk and/or adding slack-sdk in the requirements would be enough.

Perhaps monitoring section should be updated/removed in future. Using pip install spidermon[slack] (when we need Slack), pip install spidermon[amazon] (when using Amazon stuff) or pip install spidermon[jsonschema] when using JSON Schema makes more sense to me and avoid us to install libraries that won't be used and keep the libraries installed more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants