Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace slackclient with slack-sdk for Slack action #338

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

ankitjavalkar
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #338 (1f20bf7) into master (7562a67) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   74.04%   74.04%           
=======================================
  Files          68       68           
  Lines        3028     3028           
  Branches      465      465           
=======================================
  Hits         2242     2242           
  Misses        723      723           
  Partials       63       63           
Impacted Files Coverage Δ
spidermon/contrib/actions/slack/__init__.py 56.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7562a67...1f20bf7. Read the comment docs.

@rennerocha
Copy link
Collaborator

I tested locally and the changes worked fine. Slack messages are sent as before.

Copy link
Collaborator

@rennerocha rennerocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rennerocha
Copy link
Collaborator

Fix #313

@rennerocha rennerocha merged commit 72134c9 into scrapinghub:master Feb 24, 2022
@wRAR wRAR mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants