-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop official support for Python 3.5 #267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 72.52% 73.63% +1.11%
==========================================
Files 68 68
Lines 2817 2966 +149
Branches 321 321
==========================================
+ Hits 2043 2184 +141
- Misses 712 720 +8
Partials 62 62
Continue to review full report at Codecov.
|
Can also remove this: diff --git a/requirements.txt b/requirements.txt
index 1e3858b..c9ea878 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -11,5 +11,5 @@ pytest
pytest-cov
tox
sentry-sdk
-black; python_version >= '3.6'
+black
pytest-mock And add The |
I think we should open another issue to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, open an issue to investigate and remove the six
library
I created #269. Should these bits be part of this PR or that issue?
|
Hi @hugovk , |
This can be done becausespidermon will only work with Python 3.6+.
This will prevent pip from installing the project on other Python versions (https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires)
This PR solves #266
I didn't find any code that is only used for Python 3.5, so just removing it from setup, documentation and CI settings should be enough.