Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop official support for Python 3.5 #267

Merged
merged 3 commits into from
Sep 10, 2020
Merged

chore: Drop official support for Python 3.5 #267

merged 3 commits into from
Sep 10, 2020

Conversation

rennerocha
Copy link
Collaborator

@rennerocha rennerocha commented Sep 4, 2020

This PR solves #266

I didn't find any code that is only used for Python 3.5, so just removing it from setup, documentation and CI settings should be enough.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #267 into master will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   72.52%   73.63%   +1.11%     
==========================================
  Files          68       68              
  Lines        2817     2966     +149     
  Branches      321      321              
==========================================
+ Hits         2043     2184     +141     
- Misses        712      720       +8     
  Partials       62       62              
Impacted Files Coverage Δ
spidermon/contrib/actions/email/ses.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/jobs/tags.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/s3.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/files.py 0.00% <0.00%> (ø)
spidermon/contrib/monitors/mixins/stats.py 100.00% <0.00%> (ø)
spidermon/contrib/actions/sentry/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/slack/notifiers.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/telegram/notifiers.py 0.00% <0.00%> (ø)
...pidermon/contrib/pytest/plugins/filter_monitors.py 100.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a1ad1...4338d67. Read the comment docs.

@hugovk
Copy link
Contributor

hugovk commented Sep 5, 2020

Can also remove this:

diff --git a/requirements.txt b/requirements.txt
index 1e3858b..c9ea878 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -11,5 +11,5 @@ pytest
 pytest-cov
 tox
 sentry-sdk
-black; python_version >= '3.6'
+black
 pytest-mock

And add python_requires=">=3.6", to setup.py to help pip.

The six library can now be removed, and https://github.com/asottile/pyupgrade can help with that and other syntax upgrades, using the --py3-plus or even --py36-plus now.

@andersonberg
Copy link
Contributor

I think we should open another issue to remove six library and leave this PR only for the drop of Python 3.5

Copy link
Contributor

@andersonberg andersonberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, open an issue to investigate and remove the six library

@hugovk hugovk mentioned this pull request Sep 9, 2020
@hugovk
Copy link
Contributor

hugovk commented Sep 9, 2020

Please, open an issue to investigate and remove the six library

I created #269.


Should these bits be part of this PR or that issue?

Can also remove this:

diff --git a/requirements.txt b/requirements.txt
index 1e3858b..c9ea878 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -11,5 +11,5 @@ pytest
 pytest-cov
 tox
 sentry-sdk
-black; python_version >= '3.6'
+black
 pytest-mock

And add python_requires=">=3.6", to setup.py to help pip.

@rennerocha
Copy link
Collaborator Author

Hi @hugovk ,
I agree with @andersonberg to remove six in a separated PR.
The other two suggestions (python_requires and requirements.txt update) , I will add to this PR!
Thanks for suggesting that changes!

This can be done becausespidermon will only work with
Python 3.6+.
@rennerocha rennerocha merged commit a430b34 into scrapinghub:master Sep 10, 2020
@rennerocha rennerocha deleted the drop-py35-support branch September 10, 2020 13:29
@rennerocha rennerocha added this to the 1.14.0 milestone Sep 10, 2020
@rennerocha rennerocha changed the title Drop official support for Python 3.5 chore: Drop official support for Python 3.5 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants