Remove six library and upgrade Python syntax #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 73.21% 72.83% -0.38%
==========================================
Files 68 68
Lines 2972 2901 -71
Branches 324 324
==========================================
- Hits 2176 2113 -63
+ Misses 735 727 -8
Partials 61 61
Continue to review full report at Codecov.
|
Closed
Gallaecio
approved these changes
Sep 14, 2020
Gallaecio
approved these changes
Oct 25, 2020
|
Merge conflict resolved! Is there anything more I need to do for this? |
Gallaecio
reviewed
Jul 14, 2021
Gallaecio
approved these changes
Jul 27, 2021
|
One year later: is there something I can do to help get this merged? It simplifies code paths and removes a dependency, so could improve installation and code speed. Perhaps if I drop all changes other than removing the six dependency? Otherwise I don't mind closing the PR. Thank you! |
rennerocha
approved these changes
Sep 27, 2021
|
No problem, thanks! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269.
Upgrades Python syntax with https://github.com/asottile/pyupgrade using
--py36-plus