Use BaseStatMonitor to implement built-in downloader exception monitor #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 74.11% 74.06% -0.05%
==========================================
Files 68 68
Lines 3036 3031 -5
Branches 466 465 -1
==========================================
- Hits 2250 2245 -5
Misses 723 723
Partials 63 63
Continue to review full report at Codecov.
|
Gallaecio
approved these changes
Feb 8, 2022
andersonberg
approved these changes
Feb 9, 2022
rennerocha
force-pushed
the
downloader-exception-new-base-stat-class
branch
from
a136b12 to
8308246
Compare
As `downloader/exception_count` statistic is not always available (it happens only if there is some exception), we should skip the monitor if the stat is not there.
rennerocha
force-pushed
the
downloader-exception-new-base-stat-class
branch
from
8308246 to
fa51494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All built-in monitors should use
BaseStatMonitorwhen possible. So this PR will continue converting them. Also improving the documentation with a bit more details about the monitor.