Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord integration #348

Merged

Conversation

rennerocha
Copy link
Collaborator

I am creating this PR to finish the work started in #280

@rennerocha rennerocha mentioned this pull request Jun 14, 2022
3 tasks
@rennerocha rennerocha added this to the 1.17.0 milestone Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #348 (c40c40e) into master (a5d32c8) will decrease coverage by 0.53%.
The diff coverage is 49.23%.

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
- Coverage   74.57%   74.03%   -0.54%     
==========================================
  Files          70       72       +2     
  Lines        3032     3097      +65     
  Branches      467      476       +9     
==========================================
+ Hits         2261     2293      +32     
- Misses        705      738      +33     
  Partials       66       66              
Impacted Files Coverage Δ
spidermon/contrib/actions/discord/notifiers.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/discord/__init__.py 76.19% <76.19%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d32c8...c40c40e. Read the comment docs.

@rennerocha rennerocha merged commit 3539ee4 into scrapinghub:master Jun 14, 2022
@rennerocha rennerocha deleted the add-discord-integration-review branch June 14, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants