Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Ubuntu version on workflow settings. #373

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

mrwbarg
Copy link
Contributor

@mrwbarg mrwbarg commented Dec 15, 2022

Our pipeline hasn't been running for Python 3.6. This is due to an issue with github actions (actions/setup-python#544). Fixing the ubuntu version to 20.04 should fix the problem according to the comments.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 74.62% // Head: 74.62% // No change to project coverage 👍

Coverage data is based on head (9f61527) compared to base (d2ad2cd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files          73       73           
  Lines        3113     3113           
  Branches      366      366           
=======================================
  Hits         2323     2323           
  Misses        725      725           
  Partials       65       65           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@curita
Copy link
Member

curita commented Dec 15, 2022

@Gallaecio @rennerocha could you check these changes when you have the time? The CI checks don't pass for that version of python otherwise and affect all recent PRs.

@Gallaecio Gallaecio merged commit e4bf704 into scrapinghub:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants