Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding return path option for amazon ses emails #381

Merged

Conversation

further-reading
Copy link
Contributor

@further-reading further-reading commented Jan 24, 2023

Fixes #295

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 74.89% // Head: 75.85% // Increases project coverage by +0.95% 🎉

Coverage data is based on head (28380c8) compared to base (062bb7d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   74.89%   75.85%   +0.95%     
==========================================
  Files          73       73              
  Lines        3163     3168       +5     
  Branches      373      374       +1     
==========================================
+ Hits         2369     2403      +34     
+ Misses        727      695      -32     
- Partials       67       70       +3     
Impacted Files Coverage Δ
spidermon/contrib/actions/email/ses.py 85.00% <100.00%> (+85.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@further-reading further-reading changed the title [WIP] Adding return path option for amazon ses emails Adding return path option for amazon ses emails Feb 7, 2023
@further-reading
Copy link
Contributor Author

This is now ready for review!

@VMRuiz VMRuiz requested review from Gallaecio and rennerocha and removed request for Gallaecio February 8, 2023 07:28
@rennerocha rennerocha added this to the 1.18.0 milestone Feb 8, 2023
@rennerocha rennerocha merged commit 989e2ab into scrapinghub:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ReturnPath header to Amazon SES email action
3 participants