Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate schematics #399

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

mrwbarg
Copy link
Contributor

@mrwbarg mrwbarg commented Jun 5, 2023

Addresses parts of #370.

Deprecate the use of schematics as it's unlikely to receive support after Python 3.11.
This PR only removes schematics but doesn't replace it with another library (as we already have support for jsonschema).
A future PR can add support to another library such as Pydantic for example.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.17 ⚠️

Comparison is base (44d5316) 76.54% compared to head (ef9e765) 76.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   76.54%   76.37%   -0.17%     
==========================================
  Files          76       73       -3     
  Lines        3214     3103     -111     
  Branches      384      365      -19     
==========================================
- Hits         2460     2370      -90     
+ Misses        683      663      -20     
+ Partials       71       70       -1     
Impacted Files Coverage Δ
spidermon/contrib/validation/__init__.py 100.00% <ø> (ø)
spidermon/contrib/scrapy/pipelines.py 82.02% <100.00%> (-1.49%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VMRuiz VMRuiz requested review from kmike, rennerocha and Gallaecio June 7, 2023 08:38
@VMRuiz
Copy link
Collaborator

VMRuiz commented Jun 7, 2023

I'm in favor of deprecating this, but should we give some warnings first? We can add some warning messages saying that schematics support will be drop in futures versions.

@mrwbarg
Copy link
Contributor Author

mrwbarg commented Jun 7, 2023

Agreed. It's just that schematics support is already dropped. How often are new versions released that we can do thiso gradually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants