Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include replay and server modules in packages #65

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Include replay and server modules in packages #65

merged 3 commits into from
Feb 14, 2023

Conversation

zohassadar
Copy link
Contributor

Received a ModuleNotFoundError after pulling 2023.01.30. The build steps appeared to not include the replay or server modules. After modifying the build steps showed the following:

adding 'scrapli_replay/replay/__init__.py'
adding 'scrapli_replay/replay/pytest_scrapli_replay.py'
adding 'scrapli_replay/replay/replay.py'
adding 'scrapli_replay/server/__init__.py'
adding 'scrapli_replay/server/collector.py'
adding 'scrapli_replay/server/server.py'

The resulting wheel file installed successfully and did not give the ModuleNotFoundError.

@carlmontanari
Copy link
Contributor

gah, good catch. ive got some templating stuff setup for consistency for things like pyproject.toml (used to be setup.py) and the like and missed updating some things, sorry about that! I think we can actually just drop that whole tool.setuptools block (thats what I did for the other scrapli packages). I'll update your pr sometime today and get that merged and then cut a post release.

sorry about this and thanks for the fix!

@carlmontanari
Copy link
Contributor

ok, pushed w/ the removing packages part and here is what we have in dist now:

tree dist/scrapli_replay-2023.1.30
dist/scrapli_replay-2023.1.30
├── LICENSE
├── MANIFEST.in
├── PKG-INFO
├── README.md
├── pyproject.toml
├── requirements-dev.txt
├── requirements-docs.txt
├── requirements.txt
├── scrapli_replay
│   ├── __init__.py
│   ├── exceptions.py
│   ├── logging.py
│   ├── py.typed
│   ├── replay
│   │   ├── __init__.py
│   │   ├── pytest_scrapli_replay.py
│   │   └── replay.py
│   └── server
│       ├── __init__.py
│       ├── collector.py
│       └── server.py
├── scrapli_replay.egg-info
│   ├── PKG-INFO
│   ├── SOURCES.txt
│   ├── dependency_links.txt
│   ├── entry_points.txt
│   ├── requires.txt
│   └── top_level.txt
└── setup.cfg

much better :) if the looks good to you lemme know and ill merge and release .post1!

thanks again @zohassadar

@zohassadar
Copy link
Contributor Author

I made the same modification and was able to import successfully after installing the wheel. Thanks!

@carlmontanari
Copy link
Contributor

thank you! will get this merged/released!

@carlmontanari carlmontanari merged commit a88438a into scrapli:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants