Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note that SPLASH_SLOT_POLICY value isn't a string #157

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

iAnanich
Copy link
Contributor

Put a little note about what value should SPLASH_SLOT_POLICY setting have.

I want this moment to be noted in README.rst because it's a little confusing at first, when you need to import something in settings.py while Scrapy needs only string paths to mentioned objects.
I think it would be better to refactor how plugin processes settings to import needed object itself, but not inside settings.py to keep Scrapy's style.

put a little note about what value should `SPLASH_SLOT_POLICY` setting have
@kmike
Copy link
Member

kmike commented Jan 16, 2018

I think it would be better to refactor how plugin processes settings to import needed object itself, but not inside settings.py to keep Scrapy's style.

I'm fine with such change, as soon it is backwards compatible.

@kmike kmike merged commit eb0b291 into scrapy-plugins:master Jan 16, 2018
@kmike
Copy link
Member

kmike commented Jan 16, 2018

Thanks @iAnanich!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants