Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify project url and support Python - 3.8, 3.9 and 3.10 #20

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

anubhavp28
Copy link
Collaborator

@anubhavp28 anubhavp28 commented Feb 11, 2022

Hi, we could specify the project URL in setup.py. Also, we could make tox run tests with Python 3.8 and 3.9 as well.

@anubhavp28 anubhavp28 force-pushed the py3.8_and_py3.9_support branch 3 times, most recently from 3b6811e to 147823f Compare February 11, 2022 03:02
@Gallaecio
Copy link
Member

What about Python 3.10?

@anubhavp28 anubhavp28 changed the title Specify project url and support Py3.8 and Py3.9 Specify project url and support Python - 3.8, 3.9 and 3.10 Feb 11, 2022
@anubhavp28
Copy link
Collaborator Author

added Python 3.10 as well.

@Gallaecio
Copy link
Member

Thanks!

@anubhavp28
Copy link
Collaborator Author

anubhavp28 commented Feb 11, 2022

Should I merge this? I thinking of making 0.2 release of Protego. I received an email from someone about they being stuck at something because Protego doesn't support Python 3.8.

@Gallaecio
Copy link
Member

+1 from me

Copy link
Collaborator

@whalebot-helmsman whalebot-helmsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update @anubhavp28

@whalebot-helmsman whalebot-helmsman merged commit 1a64111 into scrapy:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants