-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brotlicffi support #6269
Add brotlicffi support #6269
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6269 +/- ##
==========================================
- Coverage 88.91% 88.88% -0.03%
==========================================
Files 161 161
Lines 11796 11802 +6
Branches 1914 1914
==========================================
+ Hits 10488 10490 +2
- Misses 964 968 +4
Partials 344 344
|
I guess we need an extra-deps job for PyPy? |
Or no, we install brotli* for regular tests. |
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
Yeah I replaced the PyPy pinned version for this one, should I create extra-deps? |
brotli; implementation_name != 'pypy' # optional for HTTP compress downloader middleware tests | ||
# 1.1.0 is broken on PyPy: https://github.com/google/brotli/issues/1072 | ||
brotli==1.0.9; implementation_name == 'pypy' # optional for HTTP compress downloader middleware tests | ||
brotlicffi; implementation_name == 'pypy' # optional for HTTP compress downloader middleware tests | ||
zstandard; implementation_name != 'pypy' # optional for HTTP compress downloader middleware tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so brotli and zstandard are here. It would be great if we could remove them from here and put them in the extra environments of tox.ini
instead, to make sure Scrapy works without them. (this also applies to other packages here, but they are out of scope; in fact, zstandard
is kind of out-of-scope, you could leave it here as well).
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Fix #6263