Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison of NaN with "NaN" is incorrect #197

Closed
adazem009 opened this issue Sep 9, 2023 · 1 comment
Closed

Comparison of NaN with "NaN" is incorrect #197

adazem009 opened this issue Sep 9, 2023 · 1 comment
Labels
bug Something isn't working P2 Priority: Medium

Comments

@adazem009
Copy link
Contributor

adazem009 commented Sep 9, 2023 •
edited
Loading 

Value a(Value::SpecialValue::NaN);
Value b = "NaN";

bool eq = (a == b); // false

Expected behavior:

bool eq = (a == b); // true

For some reason comparison of NaN with "nan" is correct.
@adazem009 adazem009 added bug Something isn't working P2 Priority: Medium labels Sep 9, 2023
@adazem009 adazem009 moved this from Todo to In Progress in libscratchcpp 0.2.2 Sep 28, 2023
adazem009 added a commit that referenced this issue Sep 29, 2023
@adazem009
Add test for #197
653236e
@adazem009
Copy link
Contributor Author

Fixed in #232

@github-project-automation github-project-automation bot moved this from In Progress to Needs porting in libscratchcpp 0.2.2 Sep 29, 2023
@adazem009 adazem009 moved this from Needs porting to Done in libscratchcpp 0.2.2 Sep 29, 2023
adazem009 added a commit that referenced this issue Sep 29, 2023
@adazem009
Add test for #197
6192d53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P2 Priority: Medium
Projects
No open projects
libscratchcpp 0.2.2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adazem009