Show privacy policy inside app #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also means we no longer need to disable eslint's "no-unused-expressions" rule for each route in index.js
rschamp
previously requested changes
Dec 8, 2020
cwillisf
dismissed
rschamp’s stale review
implemented a change based on this feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #97
Proposed Changes
Along with scratchfoundation/scratch-gui#6463 this change allows the Scratch app to display its privacy policy inside the app.
Primary changes:
onClickAbout, instead of just one callback function (new feature in About menu scratch-gui#6463)Supporting changes:
app.jsxandabout.jsxto return a component whichindex.jsnow renders, instead of those components rendering themselves. The newprivacy.jsxfollows this new pattern as well.Reason for Changes
Moving the "About" window from the Scratch logo to an item in a normal menu should make it easier to find.
Viewing the privacy policy in-app is not only a good idea, it's also now required by Microsoft Store policy.
Re-opening the telemetry modal on demand will allow the user to change their mind at any time, which is not required by any policy but was recommended to us and seems like a good idea anyway.