Skip to content

Conversation

@paulkaplan
Copy link
Contributor

@paulkaplan paulkaplan commented Jul 25, 2018

Enforce this by using slice so that no more are ever shown, which would mess up the layout.

Also fixes the issue where the card text could push out when translated into other languages

Resolves

What Github issue does this resolve (please include link)?

Proposed Changes

Describe what this Pull Request does

Make the deck preview wider and more padded out from the edges. Also enforce a max width to force titles to wrap.

image

Enforce this by using `slice` so that no more are ever shown, which would mess up the layout.

Also fixes the issue where the card text could push out when translated into other languages
@rschamp rschamp removed their assignment Jul 30, 2018
@carljbowman
Copy link
Contributor

Looks good to me! Thanks for making this change @paulkaplan

@paulkaplan paulkaplan merged commit 770002a into scratchfoundation:develop Jul 30, 2018
@paulkaplan paulkaplan deleted the only-two-next-steps branch July 30, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tutorial titles should wrap under thumbnails Mini Cards: Gallery card, two options instead of three

3 participants