Make Scratch logo a link#2941
Merged
rschamp merged 1 commit intoscratchfoundation:developfrom Aug 28, 2018
Merged
Conversation
Contributor
|
Why is it _blank? Doesn't it in scratch 2 replace the tab not create a new tab? |
rschamp
approved these changes
Aug 28, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
Thanks @apple502j!
@carljbowman said that opening in a new window makes sense. The behavior of clicking the logo will probably change later as we enable saving projects (we will want to save before navigating).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#2818
Proposed Changes
Make Scratch logo a link to https://scratch.mit.edu
Reason for Changes
It should be a link.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet