Fix all the little RTL layout bugs#2961
Fix all the little RTL layout bugs#2961chrisgarrity merged 3 commits intoscratchfoundation:developfrom
Conversation
- [ ] borders on toolbox and workspace mirror correctly - [ ] spacing on stage selector is correct - [ ] stage size icons are mirrored - [ ] extension library coming soon text is positioned correctly - [ ] only mirror blocks icon on the tab (others stay right-handed) - [ ] drop down icon in create variable modal has correct spacing
|
I was able to verify all of the tests mentioned in the PR description:
I noticed that the sound editor and the paint editor have non-rounded corners for the bottom edge facing the stage in both LTR and RTL, if it's a quick fix, do you want to resolve that issue completely within this PR? Otherwise, we should file it as a separate issue.
|
| border-bottom-right-radius: $space; | ||
| } | ||
|
|
||
| [dir="rtl"] .blocks :global(.injectionDiv) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kchadha
left a comment
kchadha
left a comment
There was a problem hiding this comment.
Some questions/suggestions in the comments.
This makes the editor’s asset panels match the blocks.
|
@chrisgarrity, I think this looks good now! I did find one more issue which is that the sprite info pane and the stage no longer line up on the side facing the code/sound/costume editors:
I think it's okay if this doesn't go into this PR. |
|
I think the stage lining up is related to the stage padding PR that landed last week, so it's not related to RTL. |
2 participants
Resolves
Fixes styles for RTL in various places
Test Coverage
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet